Skip to content

N°8456 - 🐛 add missing element attributes#725

Merged
jf-cbd merged 2 commits intoCombodo:support/3.2from
rudnerbjoern:fix/lnkErrorToFunctionalCI
Jun 13, 2025
Merged

N°8456 - 🐛 add missing element attributes#725
jf-cbd merged 2 commits intoCombodo:support/3.2from
rudnerbjoern:fix/lnkErrorToFunctionalCI

Conversation

@rudnerbjoern
Copy link
Contributor

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket? No
Type of change? Bug fix

Symptom (bug) / Objective (enhancement)

XML element naming of class lnkErrorToFunctionalCI was missing element attributes

Reproduction procedure (bug)

  1. On iTop 3.2.1-1z
  2. With PHP 8.1.2
  3. Install iTop
  4. look at the class lnkErrorToFunctionalCI
  5. the name is not right

Cause (bug)

wrong definition in datamodel

Proposed solution (bug and enhancement)

add missing element attributes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

Checklist of things to do before PR is ready to merge

  • ...
  • ...
  • ...

@github-project-automation github-project-automation bot moved this to First review needed in Combodo PRs dashboard Jun 13, 2025
@rudnerbjoern rudnerbjoern marked this pull request as ready for review June 13, 2025 14:27
@jf-cbd
Copy link
Member

jf-cbd commented Jun 13, 2025

Hey @rudnerbjoern, good catch, thanks for the correction :)

@jf-cbd jf-cbd changed the title 🐛 add missing element attributes N°8456 - 🐛 add missing element attributes Jun 13, 2025
@jf-cbd jf-cbd merged commit d1e6334 into Combodo:support/3.2 Jun 13, 2025
@github-project-automation github-project-automation bot moved this from First review needed to Finished in Combodo PRs dashboard Jun 13, 2025
@rudnerbjoern
Copy link
Contributor Author

Because of my new and handy datamodel validator https://rudnerbjoern.github.io/iTop-schema/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants